After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762094 - If a stored route is present in maps-places.json, placeStore is not loaded completely.
If a stored route is present in maps-places.json, placeStore is not loaded co...
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-15 17:15 UTC by Alaf
Modified: 2016-02-17 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
placestore don't try to load routes if limit is reached (1.05 KB, patch)
2016-02-16 18:08 UTC, Alaf 		committed Details | Review

Description Alaf 2016-02-15 17:15:48 UTC 
Search for a route, then search for a new place and favorite it. then restart maps.

JS LOG: Failed to parse Maps places file, subsequent writes will overwrite the file!

And latest place that is favorite after searching route is not present.
Not sure if it happens with existing stored routes. (highly likely it does).

I guess its because of out recent placeStore patch? [761533]
Comment 1 Jonas Danielsson 2016-02-16 08:11:39 UTC 
No I did not manage to reproduce this : (

Is it super-reliable for you? Does MAPS_DEBUG=1 give any more clues?
Comment 2 Alaf 2016-02-16 18:07:29 UTC 
I digged into it more. problem exists but it has nothing to do with new placeStore patch (my bad). Looking into code I realized 

if this._numRecentRoutes < this._recentRoutesLimit is false then p remains null and later it can't be set in placeStore.

https://git.gnome.org/browse/gnome-maps/tree/src/placeStore.js#n181
Comment 3 Alaf 2016-02-16 18:08:04 UTC 
Created attachment 321431 [details] [review]
placestore don't try to load routes if limit is reached
Comment 4 Jonas Danielsson 2016-02-17 11:51:26 UTC 
Review of attachment 321431 [details] [review]:

Thanks! Looks good!
Comment 5 Jonas Danielsson 2016-02-17 11:54:10 UTC 
Review of attachment 321431 [details] [review]:

pushed