GNOME Bugzilla – Bug 762076
Can't open file search result in Nautilus
Last modified: 2016-03-03 15:54:08 UTC
Hi, I've been experiencing this problem for a while. Whenever I search for a file using Gnome shell and I get the list of results of Nautilus (grouped in the File search represented with the Nautilus icon), nothing happens if I click on the Nautilus icon that has an overlay '+'. If I recall correctly, clicking on that icon should open Nautilus with the search query on the shell, but it doesn't. However, clicking on the particular file works. Thanks in advance.
I can reproduce this, however (1) other search providers work here (2) it also happens when calling gdbus call --session --dest org.gnome.Nautilus \ --object-path /org/gnome/Nautilus/SearchProvider \ --method org.gnome.Shell.SearchProvider2.LaunchSearch '["des"]' 0 manually So this looks like a nautilus issue, reassigning.
Created attachment 322990 [details] [review] general: allow to search from any part of the stack Expose the search function on the whole stack. We will need it for searches from the gnome-shell provider.
Created attachment 322991 [details] [review] shell-search-provider: make it work again We removed the search action with a rework on the whole handling of views/slots/search-query handling to decouple the code better and not expose API that is not needed outside. The problem is that we actually needed a way to search from the application, since gnome-shell search provider communicates in that way. However we missed this since it was just an action in the application, which made us don't catch this. Now we allow a search in the whole stack but in a cleaner and direct way to not be in the same situation in the future. This patch use that to make the shell search provider work again.
Created attachment 322993 [details] [review] shell-search-provider: don't crash if file doesn't have path Some backends doesn't support g_file_get_path, like the trash backends, and we were crashing trying to create a description with a NULL path. For those, just use the uri as a description.
Created attachment 322994 [details] [review] application: update modeline
Created attachment 322995 [details] [review] application: return the recent created window in open window We will need it in an upcoming patch.
Created attachment 322996 [details] [review] window-slot: remove unused priv var
Created attachment 322997 [details] [review] general: allow to search from any part of the stack Expose the search function on the whole stack. We will need it for searches from the gnome-shell provider.
Created attachment 322998 [details] [review] shell-search-provider: make it work again We removed the search action with a rework on the whole handling of views/slots/search-query handling to decouple the code better and not expose API that is not needed outside. The problem is that we actually needed a way to search from the application, since gnome-shell search provider communicates in that way. However we missed this since it was just an action in the application, which made us don't catch this. Now we allow a search in the whole stack but in a cleaner and direct way to not be in the same situation in the future. This patch use that to make the shell search provider work again.
Attachment 322993 [details] pushed as f79bed6 - shell-search-provider: don't crash if file doesn't have path Attachment 322994 [details] pushed as c8696c4 - application: update modeline Attachment 322995 [details] pushed as 01ad6bb - application: return the recent created window in open window Attachment 322996 [details] pushed as 180461a - window-slot: remove unused priv var Attachment 322997 [details] pushed as 24de92b - general: allow to search from any part of the stack Attachment 322998 [details] pushed as c07ff45 - shell-search-provider: make it work again