After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762059 - OSM doesn't ensure that TLS is available for OAuth login
OSM doesn't ensure that TLS is available for OAuth login
Status: RESOLVED OBSOLETE
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-15 03:28 UTC by Hashem Nasarat
Modified: 2018-03-26 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Depend on glib-networking for tls (1.63 KB, patch)
2016-02-15 03:28 UTC, Hashem Nasarat 		none Details | Review
osmConnection: log error if OAuth fails (1.04 KB, patch)
2016-02-15 03:28 UTC, Hashem Nasarat 		committed Details | Review

Description Hashem Nasarat 2016-02-15 03:28:23 UTC 
The following make errors explicit and make tls a build-time dependency. TLS
is a run-time dependency, but it's easiest to ensure the dependency is met at
build time as we offer no fallbacks if TLS is unavailable.

I also updated the jhbuild dependencies to gnome-maps depends on
glib-networking.
Comment 1 Hashem Nasarat 2016-02-15 03:28:27 UTC 
Created attachment 321181 [details] [review]
build: Depend on glib-networking for tls

Without glib-networking you don't have TLS and can't log in to open
street maps:

Gjs-Message: JS LOG: ERRORRest.ProxyError: TLS/SSL support not
available; install glib-networking

This autoconf snippet taken from libsoup.
Comment 2 Hashem Nasarat 2016-02-15 03:28:31 UTC 
Created attachment 321182 [details] [review]
osmConnection: log error if OAuth fails

It's not good to silently swallow errors. Adding the log helped me
discover that I needed to install glib-networking.
Comment 3 Marcus Lundblad 2016-02-15 07:27:35 UTC 
Review of attachment 321182 [details] [review]:

LGTM
Comment 4 Marcus Lundblad 2016-02-15 07:28:30 UTC 
(In reply to Hashem Nasarat from comment #2)
> Created attachment 321182 [details] [review] [review]
> osmConnection: log error if OAuth fails
> 
> It's not good to silently swallow errors. Adding the log helped me
> discover that I needed to install glib-networking.

Absolutely!
Comment 5 Hashem Nasarat 2016-02-15 08:35:44 UTC 
Comment on attachment 321182 [details] [review]
osmConnection: log error if OAuth fails

Attachment 321182 [details] pushed as f7d5610 - osmConnection: log error if OAuth fails
Comment 6 GNOME Infrastructure Team 2018-03-26 13:06:53 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-maps/issues/45.