After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762056 - Style checker should not block patch application
Style checker should not block patch application
Status: RESOLVED FIXED
Product: libgnome-games-support
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: libgames-scores maintainer(s)
libgames-scores maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-15 01:52 UTC by Michael Catanzaro
Modified: 2016-07-31 01:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
style-checker: Allow applying patches with style errors (1.40 KB, patch)
2016-07-31 01:00 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2016-02-15 01:52:13 UTC 
It's great that we have a pre-applypatch hook to catch style errors in patches.

But if I can't apply the patch, it's hard to fix the style error.


$ git bz apply 730057
Bug 730057 - Use the library libgames-scores to manage scores

298684 - Patch that uses libgames-support to manage scores (reviewed)

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Using libgames-support to track scores.
Validating the diff ...
gnome-mines.vala => Line 751 is greater than 120 charecters
Guideline checker found one issue.
We strongly recommend you to fix these.
To ignore use `git commit --no-verify`
Patch left in /tmp/Patch-that-uses-libgames-support-to-manage-scores-LSD8DD.patch
Comment 1 Michael Catanzaro 2016-07-31 00:59:58 UTC 
The following fix has been pushed:
82d6b2d style-checker: Allow applying patches with style errors
Comment 2 Michael Catanzaro 2016-07-31 01:00:28 UTC 
Created attachment 332417 [details] [review]
style-checker: Allow applying patches with style errors

Can't fix the style errors if we can't apply the patch.