After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762042 - [PATCH] Allow selecting the number of AI players for a game
[PATCH] Allow selecting the number of AI players for a game
Status: RESOLVED FIXED
Product: gnome-nibbles
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-nibbles-maint
gnome-nibbles-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-14 18:21 UTC by Iulian Radu
Modified: 2016-02-15 16:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow selecting the number of AI players (33.75 KB, patch)
2016-02-14 18:21 UTC, Iulian Radu
committed Details | Review
Allow selecting the number of AI players (34.03 KB, patch)
2016-02-15 16:34 UTC, Iulian Radu
committed Details | Review

Description Iulian Radu 2016-02-14 18:21:19 UTC
Created attachment 321143 [details] [review]
Allow selecting the number of AI players

I've added a new row of buttons so the user is now able to select the number of computer players. We have to prevent having more than 6 worms (humans + AI) but I'm not 100% sure it's a great idea to have buttons disappearing/appearing every time something is selected. I'm open to ideas.
Comment 1 Michael Catanzaro 2016-02-14 19:42:14 UTC
(In reply to Iulian Radu from comment #0)
> I'm not 100% sure it's a great idea to have buttons
> disappearing/appearing every time something is selected.

I think it actually works pretty well, except you should make sure the changing number of buttons does not affect the window size at the minimum size. E.g. select four human players, resize the window down, then select one human: the screen will expand.

Also, I think four should remain the default number of AI worms in one-player games; don't want 1v1 to be the default experience.
Comment 2 Michael Catanzaro 2016-02-14 19:43:08 UTC
We should also remember the previous setting and default to that on the next startup.
Comment 3 Iulian Radu 2016-02-15 16:34:03 UTC
Created attachment 321271 [details] [review]
Allow selecting the number of AI players