After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762032 - Titlebars of windows have become unacceptably large in 3.19.x
Titlebars of windows have become unacceptably large in 3.19.x
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.19.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-02-14 14:22 UTC by Hans de Goede
Modified: 2016-02-15 15:58 UTC
See Also:
GNOME target: 3.20
GNOME version: ---


Attachments
Adwaita Patch (2.77 KB, patch)
2016-02-15 15:02 UTC, Lapo Calamandrei
none Details | Review

Description Hans de Goede 2016-02-14 14:22:22 UTC
Hi,

This has been discussed before, and some sort of compromise where windows titlebars were still somewhat too large to my taste but at least smaller then the headerbars was reached for 3.16.x and 3.18.x, but now with 3.19.x the titlebars are much much too large again.

Start e.g. a xterm or gnome-terminal and notice how the titlebar takes more space then 3 lines of text in the terminal, this is simply unacceptable, I'm sorry but I've no other words for it having a titlebar takes more costly vertical screen space then 3 useful lines in a terminal is just plain bad.

Notice when searching for term headerbar as I forgot how it was called almost the first thing I found was:
https://www.linuxquestions.org/questions/linux-desktop-74/window-titlebar-height-in-gnome-3-19-3-a-4175572004/

And archlinux even has a special wiki page on this:
https://wiki.archlinux.org/index.php/GNOME#Titlebar_height

So I'm by no means alone in this. Please restore the titlebar height at a minimum to 3.16 / 3.18  levels and preferably make it smaller.

Regards,

Hans
Comment 1 Florian Müllner 2016-02-14 14:58:43 UTC
The titlebar's height is controlled by the text height plus padding/margin values we pick up from the GTK+ theme. Only the latter makes sense reducing, and that's up to the theme, so reassigning.
Comment 2 Lapo Calamandrei 2016-02-15 15:02:57 UTC
Created attachment 321260 [details] [review]
Adwaita Patch

No worries Hans, it's a bug. :-)
I can't test the fix atm though, would you?
Comment 3 Florian Müllner 2016-02-15 15:29:42 UTC
(In reply to Lapo Calamandrei from comment #2)
> I can't test the fix atm though, would you?

That patch makes the titlebar even bigger :-)

If it helps, you should be able to test with:

  $ GTK_CSD=1 ./examples/bp/bloatpad

from the gtk+ sources. (Unless you replace 'default-decoration' with 'ssd', which really only applies to mutter's decorations. And assuming that mutter doesn't need any more updates to pick up the correct geometry from the gtk theme ...)
Comment 4 Lapo Calamandrei 2016-02-15 15:44:19 UTC
oh, so it's csd, I was thinking about ssd, lemme see.
Comment 5 Lapo Calamandrei 2016-02-15 15:58:53 UTC
Ok, fix pushed. Thanks for spotting, closing.