GNOME Bugzilla – Bug 762025
Fix dependency cycles in bootstrap
Last modified: 2016-02-17 08:52:19 UTC
Created attachment 321106 [details] [review] autotools: add a "bootstrap" attribute to skip default dependencies Packages like autoconf/automake in the bootstrap moduleset use the autotools module type which defines default dependencies and leads to dependency cycles during bootstrap. This adds a bootstrap attribute which removes the default dependencies and allows the packages to control all dependencies. Initially the plan was to re-use the skip-autogen attribute and skip the default dependencies if "true", but skip-autogen also prevents configure from running which is still needed for those packages.
Comment on attachment 321106 [details] [review] autotools: add a "bootstrap" attribute to skip default dependencies sounds ok.
rnc validation error: ./modulesets/bootstrap.modules:46: element autotools: Relax-NG validity error : Invalid attribute bootstrap for element autotools ./modulesets/bootstrap.modules:53: element autotools: Relax-NG validity error : Invalid attribute bootstrap for element autotools ./modulesets/bootstrap.modules:63: element autotools: Relax-NG validity error : Invalid attribute bootstrap for element autotools ./modulesets/bootstrap.modules:72: element autotools: Relax-NG validity error : Invalid attribute bootstrap for element autotools ./modulesets/bootstrap.modules:81: element autotools: Relax-NG validity error : Invalid attribute bootstrap for element autotools A simple patch that adds 'attribute bootstrap { text }?,' to 'attlist.autotools' can fix it, but it seems it is better to use 'true|false' in both dtd and rnc because we don't support other values.
How can I reproduce this error?
I use trang and xmllint. $ trang modulesets/moduleset.rnc modulesets/moduleset.rng $ xmllint --noout --relaxng modulesets/moduleset.rng modulesets/*.modules
Created attachment 321462 [details] [review] Fix rnc validation by adding the new bootstrap attribute there as well. Also make it stricter and only allow true|false in both dtd/rnc.
Created attachment 321463 [details] [review] make check: validate moduleset.rnc using trang and xmllint
Thanks. Could you have a quick look at the two patches?
Thanks, these patches work for me.
Thanks. pushed to master