After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762012 - Upgrade license for all source files to GPLv3+
Upgrade license for all source files to GPLv3+
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-13 22:01 UTC by Michael Catanzaro
Modified: 2016-03-03 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Upgrade license for all source files to GPLv3+ (13.86 KB, patch)
2016-02-13 22:01 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2016-02-13 22:01:12 UTC
Since Calculator was converted to use the MPFR floating-point library, it has been conveyed under the GPLv3+ license (see the COPYING file) as that's the license of MPFR. However, I left the licenses of the individual files as GPLv2+ to make it possible to copy code from Calculator to other GNOME apps that have not upgraded to GPLv3+.

I recently realized it is super confusing to have the GPLv2+ license on individual files that use MPFR, so I've already upgraded the license on those files (mpfr.vapi, number.vala) as there is no practical way to use those files under the terms of GPLv2.

This patch bumps the GPL version on all other files. It's really optional as to whether we do this or not. At the time, I thought it best to leave it as GPLv2+ in order to facilitate more code copying; nowadays I'm inclined to reduce potential confusion by using GPLv3+ consistently, and to maximize the amount of GPLv3+ code in GNOME. MPFR's use of GPLv3+ was a good example of how one project's switch could induce others to switch; it's not so likely to happen for Calculator, but couldn't hurt.

Note that we can bump the GPL version unilaterally due to the "or (at your option) any later version" stipulation in the license headers; without this, we'd need permission from the copyright holders.
Comment 1 Michael Catanzaro 2016-02-13 22:01:15 UTC
Created attachment 321085 [details] [review]
Upgrade license for all source files to GPLv3+
Comment 2 Alberto Ruiz 2016-02-15 09:53:11 UTC
Review of attachment 321085 [details] [review]:

Looks good, go ahead :-)
Comment 3 Michael Catanzaro 2016-02-15 13:36:02 UTC
Attachment 321085 [details] pushed as ebfee6b - Upgrade license for all source files to GPLv3+