After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762009 - [review] refactor logging format and change default [th/logging-format-bgo762009]
[review] refactor logging format and change default [th/logging-format-bgo762...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-13 21:08 UTC by Thomas Haller
Modified: 2016-02-21 17:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-02-13 21:08:51 UTC 
please review
Comment 1 Thomas Haller 2016-02-13 21:09:28 UTC 
th/logging-format-bgo762009
Comment 2 Dan Williams 2016-02-20 15:48:07 UTC 
Why severe and normal instead of the more standard info and error?  Other than that, no other comments really, seems fine.
Comment 3 Thomas Haller 2016-02-21 17:49:46 UTC 
Fixed and merged as https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1f46ae57c47a7a66aa40d1885725cd1180c1517a


The change in the logging format could be controversial, and it's not actually clear that it's an improvement. I just dislike our non-aligned logs, but all the spaces are ugly too.
Dunno. Let's see how this goes, reverting will be trivial.