After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762008 - [review] kill dnsmasq process [th/kill_dnsmasq_bgo762008]
[review] kill dnsmasq process [th/kill_dnsmasq_bgo762008]
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-13 21:05 UTC by Thomas Haller
Modified: 2016-02-15 17:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-02-13 21:05:30 UTC 
I resurrected an old branch th/bgo728342_kill_dnsmask from bug 728342

Please review
Comment 1 Thomas Haller 2016-02-13 21:06:30 UTC 
th/kill_dnsmasq_bgo762008
Comment 2 Beniamino Galvani 2016-02-15 15:56:08 UTC 
> dnsmasq: kill running process from pidfile synchronously

+       exe = strrchr (cmdline_contents, '/');
+       if (   (exe && strcmp (exe, "dnsmasq") == 0)

 strcmp (exe + 1, ...)

Rest LGTM.