GNOME Bugzilla – Bug 761988
Music crashes when click on undo button.
Last modified: 2016-03-14 20:17:16 UTC
When the temporary playlist is deleted, then undo notification pops up.if you change your view to something else other then playlists like songs, artist etc and then clicked on undo button then gnome-music crashed given error on terminal.
Created attachment 321104 [details] [review] A patch to fix a problem also to show one undo notification at a time feature is included in this patch.
Personally I think that changing to another view should instead destroy the notification. Allan Day, what do you think about it?
(In reply to Felipe Borges from comment #2) > Personally I think that changing to another view should instead destroy the > notification. > > Allan Day, what do you think about it? I'd probably keep the notification around while changing views - it will help to avoid errors by keeping the undo option around.
putting crashes on the target list for now
so, is the patch ok then ?
actually this patch will only have meaning when patch on https://bugzilla.gnome.org/show_bug.cgi?id=744831 will be reviewed,beacuse if we allow one notification at a time then only i have to change a deletion index from locally to globally in patch of bug 744831 to solve this bug.
Anybody around here wo could review the two patches ? Fixing the crash would be nice
Review of attachment 321104 [details] [review]: This patch introduces a different bug. When you delete two playlists in a row and undo the last operation, it restores the previous one, not the last.
Will we get a fix for this for 3.20 ?
This issue was fixed by the patch attached to https://bugzilla.gnome.org/show_bug.cgi?id=744831 which is on master at commit 76a6e8f109807ea204cddf623a1eaf523187aa12