After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761973 - Untranslated strings in scores dialog
Untranslated strings in scores dialog
Status: RESOLVED FIXED
Product: libgnome-games-support
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Michael Catanzaro
libgames-scores maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-12 20:40 UTC by Michael Catanzaro
Modified: 2016-02-15 03:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot of scores dialog (33.56 KB, image/png)
2016-02-12 20:40 UTC, Michael Catanzaro 		  Details
Translate score categories (2.80 KB, patch)
2016-02-13 00:45 UTC, Michael Catanzaro 		committed Details | Review
Fix translations (863 bytes, patch)
2016-02-15 03:38 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2016-02-12 20:40:10 UTC 
Created attachment 321034 [details]
screenshot of scores dialog

We want to save untranslated names in the scores files, but need to display translated names to users.

Should check the status on this, see whether this is just a missing translation or if it's our fault, see whether it requires any API changes in libgames-scores... it's not lost on me that "High Scores" is also untranslated.
Comment 1 Michael Catanzaro 2016-02-13 00:45:23 UTC 
Created attachment 321052 [details] [review]
Translate score categories
Comment 2 Michael Catanzaro 2016-02-13 00:46:27 UTC 
I'm concerned about the "High Scores" label on the scores dialog. I think all strings coming from libgames-support are not displayed translated. Not sure what has gone wrong there. :/
Comment 3 Michael Catanzaro 2016-02-13 01:03:37 UTC 
Comment on attachment 321052 [details] [review]
Translate score categories

Attachment 321052 [details] pushed as c4842f0 - Translate score categories
Comment 4 Michael Catanzaro 2016-02-13 01:28:58 UTC 
(In reply to Michael Catanzaro from comment #2)
> I'm concerned about the "High Scores" label on the scores dialog. I think
> all strings coming from libgames-support are not displayed translated. Not
> sure what has gone wrong there. :/

If anyone more familiar with i18n wants to investigate, that would be very helpful. I guess we are doing something wrong as a library that wants to display translatable strings?
Comment 5 Michael Catanzaro 2016-02-15 03:38:29 UTC 
The following fix has been pushed:
45e296d Fix translations
Comment 6 Michael Catanzaro 2016-02-15 03:38:31 UTC 
Created attachment 321183 [details] [review]
Fix translations