After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761967 - (network-light) add command line argument to specify the friendly name
(network-light) add command line argument to specify the friendly name
Status: RESOLVED FIXED
Product: gupnp-tools
Classification: Other
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-12 19:41 UTC by larry.j.sachs
Modified: 2019-02-22 05:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main.c (3.34 KB, patch)
2016-02-19 20:50 UTC, larry.j.sachs 		none Details | Review
gui.h (1.12 KB, text/x-chdr)
2016-02-19 20:52 UTC, larry.j.sachs 		  Details
gui.c (7.97 KB, patch)
2016-02-19 20:53 UTC, larry.j.sachs 		none Details | Review
gui.h (1.12 KB, patch)
2016-02-19 20:54 UTC, larry.j.sachs 		none Details | Review
upnp.c (24.16 KB, patch)
2016-02-19 20:56 UTC, larry.j.sachs 		none Details | Review
upnp.h (1.26 KB, patch)
2016-02-19 20:57 UTC, larry.j.sachs 		none Details | Review
patch file (5.44 KB, patch)
2016-02-22 17:45 UTC, larry.j.sachs 		committed Details | Review

Description larry.j.sachs 2016-02-12 19:41:52 UTC 
(network-light) add command line argument to specify the friendly name and display the friendly name in the window title.  The pending pull request has code to implement.
Comment 1 Jens Georg 2016-02-19 19:36:56 UTC 
Can you also split up the commits into patches that contain only one of the two fixes each and attach them here so I can do the usual review process? Thank you.
Comment 2 larry.j.sachs 2016-02-19 20:50:56 UTC 
Created attachment 321692 [details] [review]
main.c
Comment 3 larry.j.sachs 2016-02-19 20:52:48 UTC 
Created attachment 321693 [details]
gui.h
Comment 4 larry.j.sachs 2016-02-19 20:53:48 UTC 
Created attachment 321694 [details] [review]
gui.c
Comment 5 larry.j.sachs 2016-02-19 20:54:56 UTC 
Created attachment 321695 [details] [review]
gui.h
Comment 6 larry.j.sachs 2016-02-19 20:56:35 UTC 
Created attachment 321696 [details] [review]
upnp.c
Comment 7 larry.j.sachs 2016-02-19 20:57:23 UTC 
Created attachment 321697 [details] [review]
upnp.h
Comment 8 larry.j.sachs 2016-02-19 21:01:13 UTC 
All files for this patch are now attached. I will wait until this patch is accepted (or rejected) before addressing the next enhancement request (761968)
Comment 9 Jussi Kukkonen 2016-02-22 09:47:19 UTC 
Larry, Jens was hoping to get patches as attachments, not the files themselves.

If you have a git tree with your commits, "git format-patch -2" will generate patch files for you (that's assuming there are two commits).
Comment 10 larry.j.sachs 2016-02-22 17:45:07 UTC 
Created attachment 321875 [details] [review]
patch file
Comment 11 larry.j.sachs 2016-02-22 17:46:13 UTC 
added patch file as attachment
Comment 12 Jens Georg 2016-03-26 16:46:15 UTC 
Review of attachment 321875 [details] [review]:

+1