After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761920 - initial state of the app rating dialog uses out of place fullcolor stars
initial state of the app rating dialog uses out of place fullcolor stars
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-12 10:50 UTC by Jakub Steiner
Modified: 2016-02-23 20:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
initial state (34.29 KB, image/png)
2016-02-12 10:50 UTC, Jakub Steiner
Details
rated (401.22 KB, image/png)
2016-02-12 10:50 UTC, Jakub Steiner
Details

Description Jakub Steiner 2016-02-12 10:50:20 UTC
Created attachment 320957 [details]
initial state

When you get the app rating dialog, it launches in a state where you see 5 fullcolor 4 point stars. Only after you set some rating it becomes symbolic.


Now there is a couple of approaches we can take here.

1) initial state being 0 stars, using non-starred-symbolic. Minimum rating would be 1 star and the dialog would not make the 'post' action button sensitive until you gave at least one star. 

2) Same as above, except for both states we'd be using starred-symbolic, but a blue/selection color for the active state.

3) Use a dot instead of a star for the initial state and only after you tap, switch to starred/non-starred states, allowing to give a 0 star rating (clicking outside of the stars area).

Initially I found it strange to not be able to give 0 star rating, but even ios seems to be using this effectively 4 star rating system.

I favor 1), but I'd like to hear from Allan. We definitely don't want any fullcolor icons here.
Comment 1 Jakub Steiner 2016-02-12 10:50:38 UTC
Created attachment 320958 [details]
rated
Comment 2 Richard Hughes 2016-02-12 13:10:05 UTC
I'll do this for now:

commit 4178c0f6308b9125aa8620be76aada07454dc91c
Author: Richard Hughes <richard@hughsie.com>
Date:   Fri Feb 12 13:07:59 2016 +0000

    Do not use 'help-about' for the not-yet-selected star rating
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=761920

...and leave the bug open for aday to chime in.