After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761902 - gstinfo: remove unused variable
gstinfo: remove unused variable
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-12 09:51 UTC by Håvard Graff (hgr)
Modified: 2016-02-12 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (591 bytes, patch)
2016-02-12 09:51 UTC, Håvard Graff (hgr) 		none Details | Review

Description Håvard Graff (hgr) 2016-02-12 09:51:08 UTC 
Created attachment 320940 [details] [review]
patch

This makes core warning-free for us!
Comment 1 Tim-Philipp Müller 2016-02-12 10:07:38 UTC 
This doesn't apply, and the code doesn't look familiar either, are you sure it's not a custom patch of yours?
Comment 2 Håvard Graff (hgr) 2016-02-12 10:10:36 UTC 
Whops, you are right. Got a bit lost in the patches there! :) Sorry!
Comment 3 Nicolas Dufresne (ndufresne) 2016-02-12 15:57:29 UTC 
Review of attachment 320940 [details] [review]:

::: gst/gstinfo.c
@@ +320,2 @@
   name = g_strdup (env);
   name = _replace_pattern_in_gst_debug_file_name (name, "%p", getpid ());

Isn't tmp supposed to be used here, to avoid a leak ?