After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761863 - Must use threadsafe gpgme
Must use threadsafe gpgme
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-11 14:47 UTC by Alexander Larsson
Modified: 2016-02-29 21:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that seems to fix this (1.49 KB, patch)
2016-02-11 15:14 UTC, Alexander Larsson 		reviewed Details | Review

Description Alexander Larsson 2016-02-11 14:47:46 UTC 
I'm getting this:

gnome-software: /srv/nightly/freedesktop-sdk-base/build/x86_64/tmp-glibc/work/core2-64-unknown-linux/gpgme/1.5.4-r0/gpgme-1.5.4/src/ath.c:109: _gpgme_ath_mutex_lock: Assertion `*lock == ((ath_mutex_t) 0)' failed.

gnome-software uses libostree in threads, and it seems to me that according to this:

https://www.gnupg.org/documentation/manuals/gpgme/Multi-Threading.html

we must pull in gpgme-phtread instead of gpgme. Looking into it.
Comment 1 Matthew Barnes 2016-02-11 15:12:45 UTC 
In addition, there's a couple non-threadsafe calls to gpgme_strerror() which should be switched to gpgme_strerror_r().

I *think* we're okay on calling gpgme_check_version() early enough.
Comment 2 Alexander Larsson 2016-02-11 15:14:25 UTC 
Created attachment 320886 [details] [review]
Patch that seems to fix this
Comment 3 Colin Walters 2016-02-11 15:33:31 UTC 
Review of attachment 320886 [details] [review]:

Looks OK, but let's also address comment #2 in this patch?
Comment 4 Colin Walters 2016-02-11 15:33:45 UTC 
I meant comment #1
Comment 5 Matthew Barnes 2016-02-29 21:10:28 UTC 
Colin finished this off here:
https://github.com/GNOME/ostree/pull/190