GNOME Bugzilla – Bug 761845
Add plugin for reviews.ubuntu.com
Last modified: 2016-08-16 02:37:07 UTC
Now we have review support, add a plugin to use reviews.ubuntu.com.
Created attachment 320840 [details] [review] Add an Ubuntu review plugin Rebased from work on the wip/rancell/reviews branch.
Didn't we say that G-O-A would be a better place for the auth side?
Yes, using G-O-A is a better place for the the auth UI / storage. The reason we are pursuing the current solution is: - We need to support both libaccounts (the G-O-A equivalent in Ubuntu) and G-O-A to make this work. - We don't have time to do this integration before 16.04 release. So there's a number of options we have with getting these changes into master. 1. We put the patch in as-is and iterate on it in the future. This then means GNOME Software will match what we're shipping (with a distro patch currently) and is unlikely to affect anyone else (the plugin is only applicable on Ubuntu). 2. We split the patch into the parts that are acceptable. This would be just showing the reviews, but not being able to post them. Ubuntu would distro patch in the post support and upstream it when it was in a more acceptable condition. 3. We leave all the changes in wip/rancell/reviews and leave this bug as a note so people are aware of this feature. When the plugin meets the requirements it can go into master. All three options are acceptable as the plugin nature of GNOME Software makes it not hard for us to maintain a branch / distro patch. My personal preference is option 1, though I would understand if you consider that pollutes the architecture of GNOME Software. Option 2 is a good backup in that it avoids landing a huge patch sometime into the future.
Option 2 seems like a good compromise to me; plugins are not supposed to be translatable which I think the login UI would have to be.
Created attachment 321681 [details] [review] Add a basic Ubuntu review plugin A minimal plugin that downloads review information from reviews.ubuntu.com. The aggregate rating is shown, but the reviews don't actually show because the test for this is if the plugin provides the submit functionality.
Created attachment 321682 [details] [review] Add a basic Ubuntu review plugin Self review shows an autotools variable has changed names
Looks good to me, +1 for master. Thanks.
Created attachment 321688 [details] [review] Add support for submiting reviews to reviews.ubuntu.com Patch generated by taking remaining work in progress changes from wip/rancell/reviews
I don't think plugins should be using .ui or adding translations tbh. If we do need a dialog in GS i think it needs to be made generic and moved down into ../src for all plugins to consume. I'm also not sure about shipping plugins/ubuntu-one.png as a GResource object -- surely there are trademark issues there? I still think this kind of UI belongs in g-o-a long term...
I was going to file a bug about the upstream ubuntu-reviews feature being incomplete (it doesn't have any way to log in and it doesn't disable the 'Write a Review' or 'Was this review useful' buttons when a user isn't logged in.) but I guess it's obvious that the feature is incomplete in gnome-software master currently.
I think this is all in master now; all the auth stuff was upstreamed by me and Robert.