After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761824 - bufferpool: pass acquire params to alloc_buffer
bufferpool: pass acquire params to alloc_buffer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-10 13:11 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-02-11 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
bufferpool: pass acquire params to alloc_buffer (1.35 KB, patch)
2016-02-10 13:11 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-02-10 13:11:40 UTC
When allocating a new buffer in the pool, both the do_alloc_buffer() and the
vmethod, alloc_buffer(), receive the parameter GstBufferPoolAcquireParams.

Nonetheless, when default_acquire_buffer() calls the do_alloc_buffer() it does
not pass the received GstBufferPoolAcquireParams, so when the user pass those
parameters they are ignored by alloc_buffer() vmethod.

This one-liner patch pass the received acquire params to do_alloc_buffer().
Comment 1 Víctor Manuel Jáquez Leal 2016-02-10 13:11:45 UTC
Created attachment 320797 [details] [review]
bufferpool: pass acquire params to alloc_buffer
Comment 2 Nicolas Dufresne (ndufresne) 2016-02-11 17:49:49 UTC
Attachment 320797 [details] pushed as b92d639 - bufferpool: pass acquire params to alloc_buffer