After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761819 - file-undo-operations: change trashed files matching condition
file-undo-operations: change trashed files matching condition
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-10 11:52 UTC by Razvan Chitu
Modified: 2016-02-10 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
file-undo-operations: change trashed files matching condition (2.13 KB, patch)
2016-02-10 11:53 UTC, Razvan Chitu 		committed Details | Review

Description Razvan Chitu 2016-02-10 11:52:59 UTC 
See patch.
Comment 1 Razvan Chitu 2016-02-10 11:53:02 UTC 
Created attachment 320788 [details] [review]
file-undo-operations: change trashed files matching condition

In Nautilus, undoing trash operations relies on the original path of deleted
files and their deletion time. This time value is obtained after the operation
is performed, which can lead to a mismatch. This mismatch would cause deleted
files to not be restored by an undo operation, as they would not be recognised
as being the originals.

Compare the deletion time from the file in trash with the value stored in the
undo information. If the difference is less or equal than an epsilon value,
consider the files as matching.
Comment 2 Razvan Chitu 2016-02-10 11:54:57 UTC 
Attachment 320788 [details] pushed as d1fdc58 - file-undo-operations: change trashed files matching condition
Reviewed by Carlos in IRC.