After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761803 - Fix small Keyboard Shortcuts overlay issues
Fix small Keyboard Shortcuts overlay issues
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-10 06:10 UTC by Hashem Nasarat
Modified: 2016-04-10 08:41 UTC
See Also:
GNOME target: ---
GNOME version: 3.19/3.20

Attachments
shell: Add Keyboard Shortcuts entry to App Menu (2.14 KB, patch)
2016-02-10 06:10 UTC, Hashem Nasarat 		none Details | Review
shell: fix typo in zoom in/out gesture shortcuts (1.73 KB, patch)
2016-02-10 06:10 UTC, Hashem Nasarat 		none Details | Review
shell: Mention hjkl shortcuts in help overlay (1.34 KB, patch)
2016-02-10 06:10 UTC, Hashem Nasarat 		none Details | Review
shell: Add Keyboard Shortcuts entry to App Menu (1.04 KB, patch)
2016-02-10 06:24 UTC, Hashem Nasarat 		committed Details | Review
shell: fix typo in zoom in/out gesture shortcuts (1.73 KB, patch)
2016-02-10 06:25 UTC, Hashem Nasarat 		committed Details | Review
shell: Mention hjkl shortcuts in help overlay (1.34 KB, patch)
2016-02-10 06:25 UTC, Hashem Nasarat 		committed Details | Review
shell: Update shortcut text for moving around a page (1.58 KB, patch)
2016-02-10 06:25 UTC, Hashem Nasarat 		committed Details | Review

Description Hashem Nasarat 2016-02-10 06:10:36 UTC 
See patches.
Comment 1 Hashem Nasarat 2016-02-10 06:10:40 UTC 
Created attachment 320765 [details] [review]
shell: Add Keyboard Shortcuts entry to App Menu

Previously you could only open it with the Shift + F1 or Shift + ?
shortcuts. Now it is much more discoverable. Most apps feature this
entry in the App Menu.
Comment 2 Hashem Nasarat 2016-02-10 06:10:44 UTC 
Created attachment 320766 [details] [review]
shell: fix typo in zoom in/out gesture shortcuts

Also reorder them so it's zoom in and then zoom out.
Comment 3 Hashem Nasarat 2016-02-10 06:10:48 UTC 
Created attachment 320767 [details] [review]
shell: Mention hjkl shortcuts in help overlay

They're certainly less intuitive than the direction arrows so there's
more reason to include them in the Keyboard Shortcuts overlay.
Comment 4 Hashem Nasarat 2016-02-10 06:24:56 UTC 
Created attachment 320768 [details] [review]
shell: Add Keyboard Shortcuts entry to App Menu

Previously you could only open it with the Shift + F1 or Shift + ?
shortcuts. Now it is much more discoverable. Most apps feature this
entry in the App Menu.
Comment 5 Hashem Nasarat 2016-02-10 06:25:00 UTC 
Created attachment 320769 [details] [review]
shell: fix typo in zoom in/out gesture shortcuts

Also reorder them so it's zoom in and then zoom out.
Comment 6 Hashem Nasarat 2016-02-10 06:25:05 UTC 
Created attachment 320770 [details] [review]
shell: Mention hjkl shortcuts in help overlay

They're certainly less intuitive than the direction arrows so there's
more reason to include them in the Keyboard Shortcuts overlay.
Comment 7 Hashem Nasarat 2016-02-10 06:25:09 UTC 
Created attachment 320771 [details] [review]
shell: Update shortcut text for moving around a page

Move up/down a page sounds like you're going to the next or previous
page. Also it doesn't explain moving left or right too.
Comment 8 Carlos Garcia Campos 2016-04-10 08:41:29 UTC 
Pushed all patches, thanks!