After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761783 - nautilus crashes during search
nautilus crashes during search
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Search Interface
3.19.x
Other Linux
: High critical
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-09 15:49 UTC by Mario Wenzel
Modified: 2016-11-02 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Crash in Progress (283.73 KB, video/ogg)
2016-02-09 15:49 UTC, Mario Wenzel
Details
stacktrace - maybe (3.90 KB, text/plain)
2016-02-09 18:43 UTC, Mario Wenzel
Details
Reliably crash on different machine (495.60 KB, video/webm)
2016-02-11 13:22 UTC, Mario Wenzel
Details

Description Mario Wenzel 2016-02-09 15:49:57 UTC
Created attachment 320722 [details]
Crash in Progress

(This doesn't happen in my installed nautilus 3.18.5 and also not in 3.18.5 built and run in jhbuild.)

When I search in nautilus (master) in a folder where this search has many results (as in the attached video), like searching for "f" and then I switch to search for "b", nautilus crashes with a memory access error.

What kind of traces do you need? Should I try to bisect this issue to find the offending commit?
Comment 1 Carlos Soriano 2016-02-09 17:17:26 UTC
A gdb stacktrace is what it most useful.
Comment 2 Mario Wenzel 2016-02-09 18:43:51 UTC
Created attachment 320735 [details]
stacktrace - maybe

I am pretty sure I've not done that properly (is there anything in the gnome wiki to look up when debugging c/vala applications?).
Comment 3 Carlos Soriano 2016-02-11 08:20:57 UTC
(In reply to Mario Wenzel from comment #2)
> Created attachment 320735 [details]
> stacktrace - maybe
> 
> I am pretty sure I've not done that properly (is there anything in the gnome
> wiki to look up when debugging c/vala applications?).

that is enough, although no idea what could be the issue.

A wiki for debugging is here:
https://wiki.gnome.org/Community/GettingInTouch/Bugzilla/GettingTraces
Comment 4 Mario Wenzel 2016-02-11 08:51:25 UTC
I tried and fiddled a bit and here are the current results:

* the crash does not happen in small (?) folders.
* It still happens, even when the first search already finished.
* If it happens, the second searched name is not yet added in the breadcrumb trail, it shows the current folder
* The crash does not happen, if the search has had a few minutes time to load


The last one makes me think that there may be an issue with the thumbnailer. Maybe if not all files are added to some queue yet.

I also get a lot of warnings like

(nautilus:23932): GnomeDesktop-WARNING **: Unable to create loader for mime type audio/mpeg: Unrecognized image file format

(nautilus:23932): GnomeDesktop-WARNING **: Error creating thumbnail for file:///home/maweki/Musik/Reinhard%20Mey/Reinhard%20Mey%20-%20Ich%20liebe%20Dich.mp3: Unrecognized image file format

meaning the Thumbnailer has problems accessing files because it seems to be given the wrong path (or the spaces are the issue). But the thumbnailer is still not finished when the crash doesn't happen.
Comment 5 Carlos Soriano 2016-02-11 08:56:52 UTC
Well, g_variant crash in g_variant_lock, which is for threads locking. So probably the variant is double freed or something like that, not sure why or how.

It's not a problem with the thumbnailer, thumbnails warnings are fine (it's trying to thumbnail a mp3 file, no way is gonna work :))
Comment 6 Mario Wenzel 2016-02-11 09:05:50 UTC
> It's not a problem with the thumbnailer, thumbnails warnings are fine (it's trying to thumbnail a mp3 file, no way is gonna work :))

Well, it does if the audio has embedded album art.

But you're right. I sampled a few files from the warnings and none of them do have embedded album art. The ones that don't seem to not throw warnings either.
Comment 7 Mario Wenzel 2016-02-11 13:20:31 UTC
I've now been able to reproduce this rather reliably on my Laptop machine (Fedora 23) as well. It has an SSD and an Intel Processor (as opposed to my desktop AMD/HDD setup).


1. Start nautilus with jhbuild
2. Press ctrl+f
3. press any letter (even the same every time)
4. press backspace
5. repeat quickly from 3 until crash


After the fifth time or so, it will crash.
Comment 8 Mario Wenzel 2016-02-11 13:22:47 UTC
Created attachment 320879 [details]
Reliably crash on different machine
Comment 9 Mario Wenzel 2016-02-11 13:28:15 UTC
Additionally (sorry for the many comments), I have not been able to reproduce this in an empty folder and it seems to crash more easily on folders with more entries so I do think that it has to do with some action that happens on a per-file basis.
Comment 10 Mario Wenzel 2016-11-02 08:45:33 UTC
With the new nautilus search bar I have not been able to reproduce this issue. I haven't managed to tickle any race condition out of it. Good work.