After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761746 - media-keys: Port to iio-sensor-proxy
media-keys: Port to iio-sensor-proxy
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-09 03:49 UTC by Hashem Nasarat
Modified: 2016-02-10 17:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-keys: Port to iio-sensor-proxy (7.24 KB, patch)
2016-02-09 03:50 UTC, Hashem Nasarat 		committed Details | Review

Description Hashem Nasarat 2016-02-09 03:49:56 UTC 
It looks like in versions of GNOME > 3.18 rotation lock via keyboard shortcut
or hardware button is broken. Minus one small diff context conflict, this
patch applies on the gnome-3-18 branch. I wasn't *quite* sure how to test
this, so I ended up installing gnome-3-18 (plus this commit) to /usr/local and
then pointing /etc/xdg/autostart/gnome-settings-daemon.desktop to the version
installed in /usr/local. It appeared to work and there were no errors in the
debug log (once I enabled it with --debug). If there's a better way to test
please let me know.
Comment 1 Hashem Nasarat 2016-02-09 03:50:02 UTC 
Created attachment 320680 [details] [review]
media-keys: Port to iio-sensor-proxy

commit b7f6fe30b removed the Orientation dbus name which is what
media-keys used to determine if super+o or hardware keys should
work to lock the rotation should work.
Comment 2 Hashem Nasarat 2016-02-09 03:51:42 UTC 
Sorry, things are broken in versions ≥ 3.18.
Comment 3 Rui Matos 2016-02-09 19:19:06 UTC 
Review of attachment 320680 [details] [review]:

code looks good, thanks. I can't test it though, so I'd prefer if this goes only to master for now and we can push it to gnome-3-18 later

the commit message has an extra "should work", please fix it before pushing or if you can't push I'll amend it here, let me know
Comment 4 Hashem Nasarat 2016-02-10 17:45:39 UTC 
Fixed and committed! Thanks.