After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761698 - Remove vestiges of public API
Remove vestiges of public API
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-08 04:56 UTC by Michael Catanzaro
Modified: 2016-02-08 13:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove vestiges of public API (55.49 KB, patch)
2016-02-08 04:57 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2016-02-08 04:56:59 UTC
It's been gone for years, and it's not coming back. If we support
extensions in the future, it would be via the WebExtensions API.

This makes me less annoyed by having to maintain a meaningless
distinction between installed and non-installed header files (it's been
years since any headers were installed). It also makes me less annoyed
by having to look at meaningless direct-inclusion guards. And finally,
it makes me less annoyed because each time I see those direct-inclusion
guards, I think of how they really ought to be inside the normal include
guards, rather than outside, to avoid breaking GCC and Clang's
optimization to avoid unnecessarily reading the contents of the header
file. (WebKit gets this wrong, too.) You can thank me if this makes
Epiphany compile 0.1s or so faster for you.

There are no useful changes in this commit.
Comment 1 Michael Catanzaro 2016-02-08 04:57:02 UTC
Created attachment 320600 [details] [review]
Remove vestiges of public API
Comment 2 Carlos Garcia Campos 2016-02-08 07:52:00 UTC
Review of attachment 320600 [details] [review]:

Ok, just make sure distcheck is not broken :-)
Comment 3 Michael Catanzaro 2016-02-08 13:18:09 UTC
Attachment 320600 [details] pushed as 18dc1e1 - Remove vestiges of public API