GNOME Bugzilla – Bug 761695
[lastfm] last fm registers itself with the account name and key
Last modified: 2018-09-24 09:40:40 UTC
I noticed the lua lastfm plugin registers itself as grl-lastfm-cover-account_<snip>_0-music , depending on the personal key of the user. This makes it hard to elevate the plugin rank, because the environment var GRL_PLUGIN_RANKS doesn't work with matching : grl-lastfm-cover*:4 . eg. gnome-music hardcodes plugin ranks currently and this makes that impossible it seems.
I assume this is with GOA enabled only by the way.
Created attachment 321670 [details] [review] allow glob matching of GRL_PLUGIN_RANKS Patch allows for glob pattern matching for GRL_PLUGIN_RANKS. Eg "grl-lastfm-cover*:4"
Review of attachment 321670 [details] [review]: Please include a commit message about the patch. Looks okay to me. ::: src/grl-registry.c @@ +392,3 @@ + g_hash_table_iter_init(&iter, registry->priv->ranks); + + const gchar *key = NULL; Declare/assgin it before g_hash_table_iter_init
Created attachment 329940 [details] [review] registry: Glob pattern matching for plugin ranks Source names can be constructed partially with unique identifiers, making it difficult to match directly to the static identifiers in GRL_PLUGIN_RANKS. This patch introduces glob pattern matching for GRL_PLUGIN_RANKS, which allows for example GRL_PLUGIN_RANKS="grl-lastfm-cover*:3". As mentioned in chat, this will do a glob match for every plugin that is not already directly a 1-on-1 full match with an entry in GRL_PLUGIN_RANKS. Effectively that's gonna be most plugins in most cases I think, because GRL_PLUGIN_RANKS is not always used or only lists those plugins with non-default ranks.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/78.