After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761690 - Avoid using deprecated libsoup API (and require libsoup 2.48)
Avoid using deprecated libsoup API (and require libsoup 2.48)
Status: RESOLVED FIXED
Product: libdmapsharing
Classification: Other
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: W. Michael Petullo
W. Michael Petullo
Depends on:
Blocks:
 
 
Reported: 2016-02-07 23:16 UTC by Sam Thursfield
Modified: 2016-02-08 02:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Require libsoup 2.48.0 (4.25 KB, patch)
2016-02-07 23:17 UTC, Sam Thursfield 		none Details | Review
Use new SoupServer API to create DMAPShare server. (13.31 KB, patch)
2016-02-07 23:17 UTC, Sam Thursfield 		none Details | Review
Always set base URI path (1.09 KB, patch)
2016-02-07 23:18 UTC, Sam Thursfield 		none Details | Review
Use soup_session_new() instead of deprecated soup_session_new_async() (1.08 KB, patch)
2016-02-07 23:18 UTC, Sam Thursfield 		none Details | Review

Description Sam Thursfield 2016-02-07 23:16:35 UTC 
I noticed various warnings while running Rhythmbox on Fedora 22, some of which came from libdmapshare. Patches attached which will fix all these, by using new API from libsoup 2.48 instead.
Comment 1 Sam Thursfield 2016-02-07 23:17:53 UTC 
Created attachment 320589 [details] [review]
Require libsoup 2.48.0

2.48 was released in September 2014, so should be in most distros by
now.
Comment 2 Sam Thursfield 2016-02-07 23:17:58 UTC 
Created attachment 320590 [details] [review]
Use new SoupServer API to create DMAPShare server.

This old API is deprecated, and with the new API we can report the
actual error message if we hit an error.
Comment 3 Sam Thursfield 2016-02-07 23:18:03 UTC 
Created attachment 320591 [details] [review]
Always set base URI path

A SoupURI is considered invalid if the path is NULL. Set the path of the
base URI to an empty string, instead.

This fixes a bunch of these warnings:

    (rhythmbox:32182): libsoup-WARNING **: (soup-uri.c:248):soup_uri_new_with_base: runtime check failed: (SOUP_URI_IS_VALID (base))
Comment 4 Sam Thursfield 2016-02-07 23:18:07 UTC 
Created attachment 320592 [details] [review]
Use soup_session_new() instead of deprecated soup_session_new_async()

The SoupSession class now handles async and sync communications. Since
we already call soup_session_queue_message() (which sends the message
asynchronously) there are no other changes needed.
Comment 5 Sam Thursfield 2016-02-07 23:19:50 UTC 
This would fix https://bugzilla.gnome.org/show_bug.cgi?id=727839 among other things
Comment 6 W. Michael Petullo 2016-02-08 02:02:37 UTC 
Please see libdmapsharing 2.9.33. Thank you, Sam!