GNOME Bugzilla – Bug 761686
GtkTreeView theming problems
Last modified: 2016-03-01 20:22:21 UTC
Created attachment 320585 [details] Python example 1) Calling Gtk.Widget.drag_highlight draws a border around every cell in the treeview. With 3.18 there was only a border around the whole treeview. 2) The entry used for inline editing in treeviews is way to large and clipped. The attached Python example shows both issues.
1)is fallout from the dnd change we did early in the cycle. The rough code in https://git.gnome.org/browse/gtk+/tree/gtk/theme/Adwaita/_common.scss?h=3.19.8#n3679 causes every box in the widget to get a black border. Though to be fair, I'm not sure what drag hilighting a whole treeview means conceptually and how GTK should handle that case. Just like before and hilight the whole treeview? I don't think we can hilight all the rows that would accept a drop, or can we? 2) is cause by GTK setting entry { min-height: 32px; } unconditionally. I think it should not do that for entries without frame, ie entry.flat. It certainly should not do that for entries in treeviews.
Fixed the big entries
That drag hilighting wildcard in adwaita is particularly nasty since adding a border changes the size, I have some ideas about how to avoid that, but since everything basically can be a drop target I fear we need handle that widget by widget.
The black border making the widget grow should be fixed, please check it out.
A few more (maybe related things) regarding drag highlights: gtk3-widget-factory + dragging some text: * the 3rd combobox also highlights the included icon on the right * spinbuttons don't highlight while the comboboxes do
Related, pretty ugly, but I guess it's stuff for another bug, would you file it?
Filed bug 762187
thanks