After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761667 - Crash opening associated location that has no scheme
Crash opening associated location that has no scheme
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Register
2.6.11
Other Windows
: Normal normal
: ---
Assigned To: gnucash-ui-maint
gnucash-ui-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-07 13:58 UTC by John Cummings
Modified: 2018-06-29 23:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Test for a valid uri scheme (1.07 KB, patch)
2016-09-08 14:16 UTC, Bob 		rejected Details | Review

Description John Cummings 2016-02-07 13:58:21 UTC 
Associate a location with no scheme to a transaction. For example, "dominos.com"

Later when choosing the "Open Associated File/Location" option for the transaction, GnuCash will crash.

If you add http:// or https:// to the location, GnuCash will successfully attempt to open the location.

This happens on the following OS:
Windows 8.1
Windows 7

This happens with these GnuCash versions:
2.6.11 (binary Windows download from sourceforge)
2.6.11 (setup.exe built from source using process at https://github.com/Gnucash/gnucash-on-windows)
Comment 1 John Cummings 2016-02-08 18:03:43 UTC 
Crash still happens in version "2.6.99", built from source using process at https://github.com/Gnucash/gnucash-on-windows, including the following commit:

https://github.com/Gnucash/gnucash﷒0﷓
Author: RobGowin <robgowin@gmail.com>
Date:   Tue Jan 26 09:00:54 2016 -0600
Comment 2 John Ralls 2016-02-08 19:13:00 UTC 
No surprise. It will get fixed first in the maint branch; this bug report will be updated when it does. It might be as long as a month before that's merged to master.
Comment 3 Bob 2016-09-08 14:16:32 UTC 
Created attachment 335117 [details] [review]
Test for a valid uri scheme

This patch adds a test for the URI so that it has a valid scheme before passing to the launch command to stop the Windows version from crashing. It does introduce a new string as part of the error message but as there already are some untranslated strings to do with associations I believe it should be OK to add.

This is taken from a commit to master to do with improving transaction associations.
Comment 4 John Ralls 2016-09-11 22:50:32 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.
Comment 5 John Ralls 2016-09-11 22:53:10 UTC 
Comment on attachment 335117 [details] [review]
Test for a valid uri scheme

Thanks for the effort, Bob, but that's not where the bug is. See https://github.com/Gnucash/gnucash/commit/3e30989de96b27bc3da77f85eebbfa5f59b9b127.
Comment 6 Bob 2016-09-13 13:30:49 UTC 
Not sure why I missed that, I am sure I looked at that code.

Bob
Comment 7 John Ralls 2018-06-29 23:47:07 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=761667. Please update any external references or bookmarks.