After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761628 - css: Don't use deprecated pseudo classes
css: Don't use deprecated pseudo classes
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-06 11:54 UTC by Matthias Clasen
Modified: 2016-08-15 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
css: Don't use deprecated pseudo classes (731 bytes, patch)
2016-02-06 11:54 UTC, Matthias Clasen 		reviewed Details | Review

Description Matthias Clasen 2016-02-06 11:54:20 UTC 
Remove the last use of :insensitive from gtk-style.css.
Comment 1 Matthias Clasen 2016-02-06 11:54:24 UTC 
Created attachment 320530 [details] [review]
css: Don't use deprecated pseudo classes
Comment 2 Kalev Lember 2016-02-08 10:14:38 UTC 
Review of attachment 320530 [details] [review]:

::: src/gtk-style.css
@@ +36,2 @@
 /* should be :disabled but we need to support older versions of GTK */
+.kudo-pill:disabled {

Does :disabled work with gtk 3.18? If not, maybe it would make sense to match _both_ old and new style classes, like

.kudo-pill:disabled, .kudo-pill:insensitive {
}
Comment 3 Richard Hughes 2016-02-22 16:22:52 UTC 
Will apply after branch.