After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761623 - test fails due to error message change
test fails due to error message change
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-06 10:26 UTC by Matthias Clasen
Modified: 2016-02-10 18:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (868 bytes, patch)
2016-02-06 10:26 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2016-02-06 10:26:03 UTC 
Created attachment 320524 [details] [review]
patch

One of the behave tests fails now because it expects an Overflow error but gets a Precision error. I'm not sure if this change is intentional or good, but here is a patch to update the test expectations.
Comment 1 Alberto Ruiz 2016-02-09 23:00:40 UTC 
Review of attachment 320524 [details] [review]:

How does one run this tests? They don't go through make check/distcheck, I haven't been spotting these regressions.

I suspect that some of the fixes I've pushed have modified the sort of errors that we get from MPFR.

The patch looks good please go ahead and commit.
Comment 2 Matthias Clasen 2016-02-10 17:58:32 UTC 
To run those tests locally, you can

* install python-behave
* go to tests/
* run behave . -t basic_mode

One thing I haven't figured out yet is how to convince behave to run the uninstalled binary from ../src/gnome-calculator instead of the system binary