GNOME Bugzilla – Bug 761606
Move H.265 RTP payloader/depayloader from -bad to -good
Last modified: 2016-02-17 14:19:34 UTC
Created attachment 320508 [details] [review] rtp: h265: remove codecparser dependency from h265 payloader/depayloader The only reason rtph265pay/depay are in -bad is because they depend on the codecparser library in -bad, which we can't depend on from code in -good. Turns out that all that's used is an enum for the NALs, however, so these elements could easily be moved back to -good. Don't think bug #753760 is a reason to keep it in -bad, there are no known bugs after all.
My latest change in rtph265depay, making it more consistent with the elements in gst-plugins-good/gst/rtp/, was to make this transition easier/smoother. I can sync the h265 payloader and depayloader with the spec. Make sure everything is good and well. Before making this move. I vote for it. But interested in hearing everybody else's opinions.
-bad: commit f649e85bc9e6c6f52abcdd9fe1e5de670b0f580e Author: Tim-Philipp Müller <tim@centricular.com> Date: Tue Feb 16 00:33:50 2016 +0000 rtp: move RTP H.265 payloader/depayloader to -good https://bugzilla.gnome.org/show_bug.cgi?id=761606 -good: commit 9d0f1277039ddaa147b40b5c9d8cef9761077c7f Author: Tim-Philipp Müller <tim@centricular.com> Date: Tue Feb 16 00:19:00 2016 +0000 rtp: h265: hook up move RTP H.265 payloader/depayloader to build https://bugzilla.gnome.org/show_bug.cgi?id=761606 commit 7f9f3d38b249e495fdd1e7870a1b7dbb0bbc1395 Author: Tim-Philipp Müller <tim@centricular.com> Date: Tue Feb 16 00:14:27 2016 +0000 rtp: h265: use common meta utility functions https://bugzilla.gnome.org/show_bug.cgi?id=761606 commit 714d31ce308e1d2067da494553251876aa9f68e4 Author: Tim-Philipp Müller <tim@centricular.com> Date: Fri Feb 5 18:18:31 2016 +0000 rtp: h265: remove codecparser dependency from h265 payloader/depayloader Looks like it just uses the NAL enums and nothing else from the codecparsers, and that's the only reason it had to be moved from -good to -bad when it was originally added. We can probably keep those NAL enums up to date enough, so let's remove the codecparser dependency so it can be moved back into -good. https://bugzilla.gnome.org/show_bug.cgi?id=761606 commit a70c75782b93b650124eccd07960eaac234cecfa Merge: 03e40ef 139108c Author: Tim-Philipp Müller <tim@centricular.com> Date: Tue Feb 16 00:24:58 2016 +0000 Merge branch 'plugin-move-rtp-h265' Move RTP H.265 payloader/depayloader from -bad to -good. https://bugzilla.gnome.org/show_bug.cgi?id=761606
Thanks Tim! :) I still plan to make sure the element is in sync with the spec, once I have time. Can we do something tricky with the GStreamer clocks and get 26 hour days?
Created attachment 321485 [details] [review] patch to remove duplication of read_golomb() Now that rtph265depay is in gst-plugins-good, there is no need to have two identical implementations of read_golomb()
Thanks for the review Sebastian :)