GNOME Bugzilla – Bug 761582
file-roller can not extract files with only one char in its name (a, b, c, 1, 2, 3 ... )
Last modified: 2016-05-08 10:23:32 UTC
I tested with drag and drop: http://i.imgur.com/9E8CAZF.png Ectraction not performed (null) This happens with files with one only char
Created attachment 327116 [details] [review] glib-utils: fix single-character relative basenames _g_path_get_relative_basename() incorrectly checks the length of the passed path against the length of the base directory for equality. In the case the lengths match, path + base_dir_len will not be an out-of-bounds read.
thanks your patch dont works if the file is inside a folder
Yes, it does. Upload the archive you are testing it with, please.
Okay, nevermind. It does not work if the file is deeper than the root. Investigating now.
Created attachment 327158 [details] [review] fix extracting files with single-character names Functions _g_path_get_relative_basename() and compute_base_path() incorrectly check the length of the passed path against the length of the base directory for equality. In the case the lengths match, path + base_dir_len will not be an out-of-bounds read.
ok, now works perfectly thanks
(In reply to Ernestas Kulik from comment #5) > Created attachment 327158 [details] [review] [review] > fix extracting files with single-character names > > Functions _g_path_get_relative_basename() and compute_base_path() > incorrectly check the length of the passed path against the length of > the base directory for equality. > > In the case the lengths match, path + base_dir_len will not be an > out-of-bounds read. patch applied to the master branch, thank you.