After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761557 - cursor-renderer-native: Re-use cogl's gbm device
cursor-renderer-native: Re-use cogl's gbm device
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-04 15:05 UTC by Rui Matos
Modified: 2016-02-04 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
cursor-renderer-native: Re-use cogl's gbm device (1.58 KB, patch)
2016-02-04 15:05 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2016-02-04 15:05:11 UTC
Instancing a gbm device without initializing EGL with it means that it
won't be able to import wl_drm buffers. Instead, let's re-use cogl's
gbm device which is already properly initialized.
Comment 1 Rui Matos 2016-02-04 15:05:16 UTC
Created attachment 320442 [details] [review]
cursor-renderer-native: Re-use cogl's gbm device
Comment 2 Ray Strode [halfline] 2016-02-04 15:24:51 UTC
Review of attachment 320442 [details] [review]:

nice find, makes sense to me.  The alternative would be to call eglBindWaylandDisplay but having two devices is clearly wrong.
Comment 3 Rui Matos 2016-02-04 17:23:56 UTC
Attachment 320442 [details] pushed as 55eef2d - cursor-renderer-native: Re-use cogl's gbm device