GNOME Bugzilla – Bug 761477
resindvd: "Highlight" event uses GstEvent::timestamp
Last modified: 2018-05-06 15:23:27 UTC
Instead, it should store timestamp in GstStructure. Timestamp field is not used and will be removed soon. https://bugzilla.gnome.org/show_bug.cgi?id=761462
My recollection is that dvdspu used the event timestamp to wait until the right video frame when starting to draw new buttons, but I can't see where it does that in dvdspu - so either my recollection is faulty or the code got lost at some point. Either way, the timestamp could be in the GstStructure easily.
At least, in case someone suddenly will realise that there is no timestamp anymore, one will be able to find this page.
The code I was thinking of here is actually in the older dvdsubdec element in gst-plugins-ugly, where it uses the event PTS. I think it's fine to change this in both places to put the PTS into the structure, and the highlight PTS is not used very much in any case.
dvdsubdec: Take the highlight event from the structure. Don't use GST_EVENT_TIMESTAMP to transfer any PTS associated with a highlight event, instead store it in the event structure directly, as GstEvent::timestamp will disappear in GStreamer 2.0 https://bugzilla.gnome.org/show_bug.cgi?id=761477
commit 1b6cc98aa5a7a16e5662d71d5f7a911249c49abc Author: Jan Schmidt <jan@centricular.com> Date: Fri May 4 22:24:18 2018 +1000 resindvsrc: Don't use the GST_EVENT_TIMESTAMP Store a PTS of a highlight event directly into the event structure, rather than the GST_EVENT_TIMESTAMP that will probably be removed in GStreamer 2.0, and is hardly used. https://bugzilla.gnome.org/show_bug.cgi?id=761477