After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761474 - x11: Scaling factor is applied twice on screen work area
x11: Scaling factor is applied twice on screen work area
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-02-02 20:40 UTC by fakey
Modified: 2016-02-24 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x11: don't apply scaling factor twice (1.16 KB, patch)
2016-02-02 20:41 UTC, fakey 		committed Details | Review

Description fakey 2016-02-02 20:40:13 UTC 
In the fallback case when get_work_area () terminates early, it scales the screen width and height down by the window scaling factor, but those values are already scaled down in gdk_x11_screen_get_width () and gdk_x11_screen_get_height ().

It's causing this bug: https://bugs.launchpad.net/ubuntu/+source/unity-greeter/+bug/1434094.
Comment 1 fakey 2016-02-02 20:41:14 UTC 
Created attachment 320294 [details] [review]
x11: don't apply scaling factor twice
Comment 2 Matthias Clasen 2016-02-04 15:22:10 UTC 
Review of attachment 320294 [details] [review]:

Looks good to me
Comment 3 Matthias Clasen 2016-02-04 15:22:55 UTC 
Review of attachment 320294 [details] [review]:

Looks good to me
Comment 4 Iain Lane 2016-02-24 17:16:46 UTC 
ok to cherry-pick this to 3.18?
Comment 5 Matthias Clasen 2016-02-24 17:37:19 UTC 
yes, please. Too bad I missed it for the 3.18 release I just did
Comment 6 Iain Lane 2016-02-24 17:51:06 UTC 
done. I noticed because we have this in Ubuntu and I was packaging the new release up. Oh well :)