After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761471 - Do not allow ligatures in log output
Do not allow ligatures in log output
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: doxywizard
1.8.9.1
Other All
: Normal minor
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2016-02-02 19:31 UTC by Pander
Modified: 2016-09-05 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Unwanted ligatures (108.65 KB, image/png)
2016-02-02 19:31 UTC, Pander 		Details

Description Pander 2016-02-02 19:31:18 UTC 
Created attachment 320290 [details]
Unwanted ligatures

Please, do not allow ligatures, such as "fi" for "fi", in log output. This is a common problem these days with many monospaced rendering and has to be disabled explicitly. See attachment for example.
Comment 1 albert 2016-02-03 14:43:40 UTC 
I don't see this behavior on my, Window 7, system.
From the code I see:
m_outputLog = new QTextEdit;
m_outputLog->setReadOnly(true);
m_outputLog->setFontFamily(QString::fromLatin1("courier"));

So my guess is that the courier font cannot be found in your case.

Which platform are you using?
Comment 2 Pander 2016-02-03 16:14:48 UTC 
Ubuntu latest and I have that font.

This is a common default setting on (HTML) text rendering that is highly undesirable when displaying text in monospaced font. That it shows fi ligatures indicates that there is very good font support, as these are special font features.

In CSS, this is fixed by

style='font-family: courier; -o-font-feature-settings: "liga" off; -o-font-variant-ligatures: none; -moz-font-feature-settings: "liga" off; -moz-font-variant-ligatures: none; -webkit-font-feature-settings: "liga" off; -webkit-font-variant-ligatures: none; font-feature-settings: "liga" off; font-variant-ligatures: none; '
Comment 3 Dimitri van Heesch 2016-02-04 19:15:20 UTC 
@Pander: Maybe it would be a fix to use 

  m_outputLog = new QPlainTextEdit

instead of 

  m_outputLog = new QTextEdit. 

in addon/doxywizard/doxywizard.cpp

Can you try if that helps?
Comment 4 Pander 2016-02-04 22:11:59 UTC 
For this project, I am only a user. Please ask somebody else to reproduce and confirm the proposed fix. Thanks.
Comment 5 albert 2016-02-06 19:03:14 UTC 
On RHEL6 this problem didn't show but the text was displayed in italics.
Changing to QPlainTextEdit didn't solve the problem.
With QTextBrowser it was possible to overcome the problem.

I've just pushed a proposed patch to github (pull request 451)
Comment 6 albert 2016-09-03 11:13:12 UTC 
Code has been integrated in master branch on github
Comment 7 Dimitri van Heesch 2016-09-05 13:45:53 UTC 
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.12. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information 
that you think can be relevant (preferably in the form of a self-contained example).