After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761436 - A few misc fixes
A few misc fixes
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-01 23:08 UTC by Cosimo Cecchi
Modified: 2016-02-03 17:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window-base: remove unused code (1.49 KB, patch)
2016-02-01 23:08 UTC, Cosimo Cecchi 		committed Details | Review
window-base: don't call gtk_window_set_icon_list() (1.90 KB, patch)
2016-02-01 23:08 UTC, Cosimo Cecchi 		committed Details | Review
bijiben: simplify code (3.71 KB, patch)
2016-02-01 23:08 UTC, Cosimo Cecchi 		committed Details | Review
bjb-app-menu: use logo-icon-name to add an icon to about dialog (2.53 KB, patch)
2016-02-01 23:08 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-02-01 23:08:00 UTC 
More work towards removing hardcoded icon path and fixes blurry icon in the about dialog.
Comment 1 Cosimo Cecchi 2016-02-01 23:08:03 UTC 
Created attachment 320240 [details] [review]
window-base: remove unused code
Comment 2 Cosimo Cecchi 2016-02-01 23:08:06 UTC 
Created attachment 320241 [details] [review]
window-base: don't call gtk_window_set_icon_list()

This is not needed; the desktop shell will automatically read the icon
at the appropriate size from the desktop file.
Comment 3 Cosimo Cecchi 2016-02-01 23:08:09 UTC 
Created attachment 320242 [details] [review]
bijiben: simplify code

We don't need to pass an error around here.
Comment 4 Cosimo Cecchi 2016-02-01 23:08:12 UTC 
Created attachment 320243 [details] [review]
bjb-app-menu: use logo-icon-name to add an icon to about dialog

This was previously displayed because we were calling
gtk_window_set_icon_list(), but that was wrong as it will hardcode a
specific resolution to the icon.
The correct way to do this is to just use the "logo-icon-name" property
of GtkAboutDialog.
Comment 5 Cosimo Cecchi 2016-02-03 17:25:19 UTC 
Thanks!

Attachment 320240 [details] pushed as ff211a9 - window-base: remove unused code
Attachment 320241 [details] pushed as 121f0a3 - window-base: don't call gtk_window_set_icon_list()
Attachment 320242 [details] pushed as ac78022 - bijiben: simplify code
Attachment 320243 [details] pushed as 2544124 - bjb-app-menu: use logo-icon-name to add an icon to about dialog