GNOME Bugzilla – Bug 761422
Add context to strings in the shortcut window
Last modified: 2016-09-20 08:15:55 UTC
Created attachment 320222 [details] [review] Add context to strings in the shortcut window Attached patch adds context to strings in the shortcut window, as discussed on d-d-l. https://mail.gnome.org/archives/desktop-devel-list/2016-February/msg00000.html
Created attachment 320413 [details] [review] Add context to strings in the shortcut window v2 Added a description and an URL to this bug.
Review of attachment 320413 [details] [review]: I'll push with that one minor nitpick and also change the shortlog a bit. ::: data/ui/kbd-shortcuts-window.ui @@ +16,3 @@ <object class="GtkShortcutsGroup"> <property name="visible">1</property> + <property name="title" translatable="yes" context="shortcut window">Overview</property> If the point is to help translators, I'd use a more verbose string: "keyboard shortcuts window"
I'd prefer to stick with what every other module already has. It doesn't need to be that descriptive anyway, as context is used primarily to disambiguate strings, not provide comments. You have the last word on this, of course.
(In reply to Piotr Drąg from comment #3) > I'd prefer to stick with what every other module already has. It doesn't > need to be that descriptive anyway, as context is used primarily to > disambiguate strings, not provide comments. Hm.. ah ok. Consistency is important, of course. :) Thanks for the patch.