GNOME Bugzilla – Bug 761394
Composer does not remember if a signature was set to 'None' in Drafts/Templates
Last modified: 2016-03-12 01:41:47 UTC
Moving this from a downstream bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1303481 Description of problem: If the signature setting is changed and the email is saved (draft copy) then reopened the signature setting is reset to the default value and not the value used when the email was saved Version-Release number of selected component (if applicable): evolution 3.18.4 How reproducible: Yes Steps to Reproduce: 1. Open new email. 2. Change signature setting to something like "None". 3. Save email in Draft 4. Open email again and setting is not "None" Actual results: Signature block added Expected results: No signature block
(In reply to Milan Crha from comment #0) > If the signature setting is changed and the email is saved (draft copy) then > reopened the signature setting is reset to the default value and not the > value used when the email was saved This is not true. It is picking the signature from the draft/template. But it does not work when the signature is set to None.
I stand corrected. It does not happen for all choices. This only happens (it appears) if you set the signature to "none". When you reopen it, it picks the default one again. It fails to remember that "none" was chosen as the signature.
Fixed with following commits: Bug 761394 - Composer does not remember if a signature was set to 'None' in Drafts/Templates Reflect in the HTML code of a message that there is no signature set, so we behave consistently when opening a message from drats or templates. Improve the code to create the DOM structure of the signature instead of constructing it from the string. Also save the signature ID to the element id attribute instead of the name attribute (as element's id was set to '1' but not never used). commit 553b551 in the master branch for Evolution 3.19.90+ commit 8179d55 in the gnome-3-18 branch for Evolution 3.18.5+
I have used 3.18.5.1 and the problem appears to be fixed. Thanks.