After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761387 - Handle vertically maximized window state from Windows 7
Handle vertically maximized window state from Windows 7
Status: RESOLVED DUPLICATE of bug 698652
Product: gtk+
Classification: Platform
Component: Backend: Win32
Other Linux
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
Depends on:
Reported: 2016-02-01 07:58 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2016-02-04 07:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

handle-vertically-maximized-windows (1.46 KB, patch)
2016-02-01 07:59 UTC, Ignacio Casal Quinteiro (nacho)
needs-work Details | Review

Description Ignacio Casal Quinteiro (nacho) 2016-02-01 07:58:34 UTC
Patch from muntyan coming. I am adding it here so we can review it and ask for some questions.
Comment 1 Ignacio Casal Quinteiro (nacho) 2016-02-01 07:59:37 UTC
Created attachment 320167 [details] [review]
Comment 2 Ignacio Casal Quinteiro (nacho) 2016-02-01 08:02:25 UTC
Review of attachment 320167 [details] [review]:

See the comments.

::: gdk/win32/gdkwindow-win32.c
@@ +3586,3 @@
                   guint32    timestamp)
+  GdkWindowObject *private = (GdkWindowObject *) window;

this I would rename it to window_object instead of private

@@ +3600,2 @@
     ShowWindow (GDK_WINDOW_HWND (window), SW_SHOWMAXIMIZED);
+  else if (private->state & GDK_WINDOW_STATE_ICONIFIED)

I suppose these 2 lines are the real bug? if they are as I understand it, I would prefer this patch split into 2 patches. One fixing the real bug and another patch with the other changes to optimize
Comment 3 Yevgen Muntyan 2016-02-04 07:40:09 UTC
Dup of 698652.
Comment 4 Ignacio Casal Quinteiro (nacho) 2016-02-04 07:45:18 UTC
Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 698652 ***