GNOME Bugzilla – Bug 761387
Handle vertically maximized window state from Windows 7
Last modified: 2016-02-04 07:45:18 UTC
Patch from muntyan coming. I am adding it here so we can review it and ask for some questions.
Created attachment 320167 [details] [review]
Review of attachment 320167 [details] [review]:
See the comments.
@@ +3586,3 @@
+ GdkWindowObject *private = (GdkWindowObject *) window;
this I would rename it to window_object instead of private
@@ +3600,2 @@
ShowWindow (GDK_WINDOW_HWND (window), SW_SHOWMAXIMIZED);
+ else if (private->state & GDK_WINDOW_STATE_ICONIFIED)
I suppose these 2 lines are the real bug? if they are as I understand it, I would prefer this patch split into 2 patches. One fixing the real bug and another patch with the other changes to optimize
Dup of 698652.
Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.
*** This bug has been marked as a duplicate of bug 698652 ***