After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761364 - Glade ignores headerbar slot in a CSD window
Glade ignores headerbar slot in a CSD window
Status: RESOLVED OBSOLETE
Product: glade
Classification: Applications
Component: user interface
git master
Other All
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-31 16:21 UTC by LRN
Modified: 2018-03-26 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description LRN 2016-01-31 16:21:17 UTC
Create a toplevel
Change the toplevel to be CSD
Observe that the toplevel has no headerbar and no headerbar slot.
Run.
Observe that the toplevel does have a headerbar when realized.

Load a project that has a CSD toplevel with a headerbar
Observer that the toplevel has no headerbar
Select headerbar in the widget tree
Observe that selection is rendered as if headerbar slot has 0 height.

Expected behaivour: Glade shows headerbar for CSD windows
Actual behaviour: Glade does not show headerbar for CSD windows

gtk master, glade master

This bug was introduced during the DX hackfest.
Comment 1 LRN 2016-02-03 06:07:39 UTC
Oh, yeah, you might need to set project GTK version to 3.18, since 3.20 is not out yet, otherwise running the project won't work correctly.
Comment 2 LRN 2016-03-16 12:27:14 UTC
Interesting thing i've noticed today:
If one creates a non-generic window in Glade (for example, "Dialog Box"), and CSD is turned on by default, a CSD dialog is created. If then "Client side window decorations" is switched on for that dialog, it loses the GTK-provided headerbar and allows user to put a custom headerbar.

This might indicate that the problem is in Glade somehow not being ready/able to add/remove headerbar slot to a window after it's created, or maybe it's just GTK that doesn't allow that.
Comment 3 Tristan Van Berkom 2016-03-16 12:47:34 UTC
FWIW, headerbars in dialogs are not a "thing"

See bug 757562.

At this time Glade mistakenly allows one to set "Use client side window decorations" in a GtkDialog, but this should be disabled.

For now, filed this as bug 763750.

Need to re-verify this with GTK+ master, this seems to be a regression but is likely fixed by now.
Comment 4 Emmanuel Pacaud 2016-07-07 12:33:38 UTC
(In reply to Tristan Van Berkom from comment #3)
> Need to re-verify this with GTK+ master, this seems to be a regression but
> is likely fixed by now.

It looks like it has been fixed by this commit:

https://git.gnome.org/browse/glade/commit/?id=7b0aa0166486e5c85973960ebb54f31790754ffc

This bug seems to be a dup of https://bugzilla.gnome.org/show_bug.cgi?id=765885
Comment 5 GNOME Infrastructure Team 2018-03-26 15:52:05 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glade/issues/228.