GNOME Bugzilla – Bug 761339
[PATCH] skip gtk_widget_path_iter_add_qclass from g-ir-scanner
Last modified: 2016-02-05 07:31:13 UTC
Created attachment 320094 [details] [review] patch Instructs g-ir-scanner to skip this function as per note in gtkwidgetpath.h.
Review of attachment 320094 [details] [review]: ::: gtk/gtkwidgetpath.c @@ +850,2 @@ void gtk_widget_path_iter_add_qclass (GtkWidgetPath *path, Mismatch between the function name and the comment (class vs qclass)
Created attachment 320125 [details] [review] skip private gtk_widget_path_iter_add_qclass from g-ir-scanner Fixed, thanks!
Review of attachment 320125 [details] [review]: Sorry for not looking in depth earlier - I think the better fix is to move that function into a new gtkwidgetpathprivate.h header, and include that where the function is used.
I afraid I'm not so proficient with C and GTK internals to do what you're asking me to. That's why it could take so long so the fix might even not make into 3.20. Moreover, my patch merely fixes someone's oversight, so how about this: my patch gets applied, GTK v3.20 gets released not being affected by this issue, and covering technical debt by implementing better fix goes to someone who introduced the issue (or his reviewer), or a volunteer. Does that make sense?
i'll get around to it myself before 3.20
(In reply to Matthias Clasen from comment #5) > i'll get around to it myself before 3.20 Thank you in advance! Can you post link to new issue here so we could track its' progress in haskell-gi [1]? [1]: https://github.com/haskell-gi/haskell-gi/blob/master/bindings/Gtk/Gtk.overrides#L11