After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761337 - Fix some annotations
Fix some annotations
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: introspection
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-01-30 20:34 UTC by Rico Tzschichholz
Modified: 2016-02-02 09:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
socket: Fix annotation of g_socket_receive_message (1.65 KB, patch)
2016-01-30 20:34 UTC, Rico Tzschichholz 		committed Details | Review
application: Fix annoation of g_application_add_option_group (809 bytes, patch)
2016-01-30 20:35 UTC, Rico Tzschichholz 		committed Details | Review

Description Rico Tzschichholz 2016-01-30 20:34:16 UTC 
Some patches which are providing annotions fixes.
Comment 1 Rico Tzschichholz 2016-01-30 20:34:20 UTC 
Created attachment 320092 [details] [review]
socket: Fix annotation of g_socket_receive_message
Comment 2 Rico Tzschichholz 2016-01-30 20:35:26 UTC 
Created attachment 320093 [details] [review]
application: Fix annoation of g_application_add_option_group
Comment 3 Allison Karlitskaya (desrt) 2016-02-02 09:04:37 UTC 
Review of attachment 320092 [details] [review]:

Looks good.

::: gio/gsocket.c
@@ +5230,3 @@
  *    elements in @messages, or %NULL
+ * @flags: (inout): a pointer to an int containing #GSocketMsgFlags flags
+ * @cancellable: (nullable): a %GCancellable or %NULL

#GCancellable is always nullable, so this annotation can actually be removed.
Comment 4 Allison Karlitskaya (desrt) 2016-02-02 09:05:29 UTC 
Review of attachment 320093 [details] [review]:

Nice catch.  Thanks!
Comment 5 Rico Tzschichholz 2016-02-02 09:14:18 UTC 
Comment on attachment 320093 [details] [review]
application: Fix annoation of g_application_add_option_group

Attachment 320093 [details] pushed as ec173eb - application: Fix annoation of g_application_add_option_group
Comment 6 Rico Tzschichholz 2016-02-02 09:19:09 UTC 
Attachment 320092 [details] pushed as d268d9f - socket: Fix annotation of g_socket_receive_message