After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761300 - Change icon to use app ID
Change icon to use app ID
Status: RESOLVED FIXED
Product: gnome-todo
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-29 16:46 UTC by Cosimo Cecchi
Modified: 2016-01-30 01:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change icon to use app ID (6.76 KB, patch)
2016-01-29 16:52 UTC, Cosimo Cecchi 		none Details | Review

Description Cosimo Cecchi 2016-01-29 16:46:22 UTC 
See attached patch.
Comment 1 Cosimo Cecchi 2016-01-29 16:52:45 UTC 
Created attachment 320022 [details] [review]
Change icon to use app ID

In preparation for xdg-app.
Comment 2 Georges Basile Stavracas Neto 2016-01-29 19:09:32 UTC 
Thanks for the work. The patch itself looks good, but I have one concern: how much To Do is desired to be sandboxed? It uses deep GOA integration, which will be a considerable issue in the future.
Comment 3 Cosimo Cecchi 2016-01-29 23:44:08 UTC 
Georges, GOA will work fine with the current xdg-app bundle implementation. I actually tested the bundle from Alex's gnome-apps-nightly and it works well with GOA.
Can I commit the patch?
Comment 4 Georges Basile Stavracas Neto 2016-01-30 00:50:51 UTC 
Sure, go ahead - and thanks for fixing it.
Comment 5 Cosimo Cecchi 2016-01-30 01:00:17 UTC 
Thanks!

Attachment 320022 [details] pushed as 8e95187 - Change icon to use app ID