After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761288 - roomList: right-click on row triggers popover, left-click on rowheader triggers popover
roomList: right-click on row triggers popover, left-click on rowheader trigge...
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-29 13:39 UTC by Bastian Ilsø
Modified: 2016-01-29 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
roomList: Allow right-clicks to trigger header popover (1.53 KB, patch)
2016-01-29 14:43 UTC, Florian Müllner 		committed Details | Review

Description Bastian Ilsø 2016-01-29 13:39:12 UTC 
I'm finding myself trying to right-click the rowheader to trigger the connection popover (since that's how you trigger the popover for normal rows).

Since our rowheaders look very identical to rows, perhaps we could begin to trigger the popover on both left-click and right-click?
Comment 1 Florian Müllner 2016-01-29 14:43:38 UTC 
The following fix has been pushed:
fbb86b2 roomList: Allow right-clicks to trigger header popover
Comment 2 Florian Müllner 2016-01-29 14:43:42 UTC 
Created attachment 320020 [details] [review]
roomList: Allow right-clicks to trigger header popover

Unlike rows, where we distinguish between primary (activating the room) and
secondary action (showing the context popover), room headers only have a
single possible action - triggering the popover. It isn't really useful to
restrict that to left clicks, so simply treat secondary button events as
primary ones.