After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761281 - No way to undo connection removal
No way to undo connection removal
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
: 722509 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-01-29 11:16 UTC by Bastian Ilsø
Modified: 2016-02-02 22:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mockup of notification shown after user pressed "remove" for a given connection. (42.61 KB, image/png)
2016-01-29 11:16 UTC, Bastian Ilsø
  Details
application: Allow to undo connection removal (3.79 KB, patch)
2016-01-29 12:18 UTC, Florian Müllner
committed Details | Review
Undo notification (4.93 KB, image/png)
2016-01-29 12:19 UTC, Florian Müllner
  Details

Description Bastian Ilsø 2016-01-29 11:16:37 UTC
Created attachment 320011 [details]
mockup of notification shown after user pressed "remove" for a given connection.

As inaccurate as my wireless mouse is, it took less than hour for me to misclick "Remove" instead of "Reconnect".

It would be nice to provide an undo option for this. See attached mockup.
Comment 1 Florian Müllner 2016-01-29 12:18:31 UTC
Created attachment 320017 [details] [review]
application: Allow to undo connection removal

Since commit 6ef2e57371aa added a "Remove" menu action to the room
header popover, it is now a lot easier to remove a connection by
accident. We should be more forgiving in that case, so show an app
notification that allows the user to undo the operation, and only
actually remove the account when the notification has been dismissed
or timed out.
Comment 2 Florian Müllner 2016-01-29 12:19:54 UTC
Created attachment 320018 [details]
Undo notification
Comment 3 Bastian Ilsø 2016-01-29 13:11:44 UTC
Review of attachment 320017 [details] [review]:

Maybe we should have some max-width / label wrapping for our notifications since we can't know how long the connection's name will be and can't know how long the translation of labels can be.

Beyond that, looks good to me.
Comment 4 Florian Müllner 2016-01-29 14:45:50 UTC
Attachment 320017 [details] pushed as 520cf10 - application: Allow to undo connection removal
Comment 5 Florian Müllner 2016-02-02 22:54:05 UTC
*** Bug 722509 has been marked as a duplicate of this bug. ***