After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761259 - Don't use GOA on Unity
Don't use GOA on Unity
Status: RESOLVED WONTFIX
Product: gnome-calendar
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-28 16:10 UTC by Iain Lane
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Hide GOA sources on Unity (3.43 KB, patch)
2016-01-28 16:10 UTC, Iain Lane
none Details | Review
Spawn Ubuntu's credentials panel instead of the GOA online-accounts one on Unity (4.72 KB, patch)
2016-01-28 16:10 UTC, Iain Lane
none Details | Review
updated version calling the right binary (5.09 KB, patch)
2016-03-02 18:30 UTC, Sebastien Bacher
none Details | Review

Description Iain Lane 2016-01-28 16:10:47 UTC
Under Unity (where we ship gnome-calendar by default now, starting with 16.04 LTS), we add accounts using Ubuntu Online Accounts, not Gnome Online Accounts. It's the same idea but two different services and APIs. At the end of it (from gnome-calendar's POV), it's still EDS.

So the direct integration with GOA in gnome-calendar doesn't really work for us. We would ideally provide an equivalent implemention for UOA, but that would be a fair chunk of work. The idea that I had is to instead simply disable and hide the direct integration under Unity and direct users to the control-center for this instead.

What do you think about having these patches upstream?
Comment 1 Iain Lane 2016-01-28 16:10:52 UTC
Created attachment 319951 [details] [review]
Hide GOA sources on Unity
Comment 2 Iain Lane 2016-01-28 16:10:59 UTC
Created attachment 319952 [details] [review]
Spawn Ubuntu's credentials panel instead of the GOA online-accounts one on Unity

Show the cog button to launch the control-center in the remaining
GtkGrid in this case.
Comment 3 Georges Basile Stavracas Neto 2016-01-30 14:11:12 UTC
I'm not particularly in favor of having a downstream fix applied to the upstream tree. If we're going to support Ubuntu specificities, the only way to be fair is to support ~every~ distro's specificities - which can grow to be an exponential problem very quickly. But that's just my position.

I'm NOT closing this bug for now, let's wait for Erick's input on this issue.
Comment 4 Iain Lane 2016-01-31 18:03:53 UTC
It's fair enough - I will note if it helps that UOA has upstream support in e-d-s and evolution, although I'm not actually adding support for it here of course. :)

Hopefully it won't be a problem for you - a few other projects have this kind of thing, for example because we like menubars to be handled a bit differently - but I understand if you don't want it, we can carry this ourselves if necessary.
Comment 5 Matthias Clasen 2016-01-31 23:50:20 UTC
Here is an alternative proposal: how about implementing goa APIs in uoa ?
Comment 6 Iain Lane 2016-02-01 08:32:31 UTC
(In reply to Matthias Clasen from comment #5)
> Here is an alternative proposal: how about implementing goa APIs in uoa ?

Maybe that would be possible, I don't particularly know these APIs. That's definitely a bigger project though, and in the meantime it would be good to see this bug solved.
Comment 7 Sebastien Bacher 2016-03-02 18:30:17 UTC
Created attachment 322902 [details] [review]
updated version calling the right binary

Unity uses unity-control-center, updating the second patch to reflect that (also display an error when the settings can't be started)
Comment 8 Matthias Clasen 2016-03-02 18:32:50 UTC
I think thats a fine patch to keep downstream.

I'll start pushing back a bit against the notion that you can use gnome apps, but expect us to carry the cost of adapting them to your alternative backends.
Comment 9 Iain Lane 2016-03-02 18:49:22 UTC
(In reply to Matthias Clasen from comment #8)
> I think thats a fine patch to keep downstream.
> 
> I'll start pushing back a bit against the notion that you can use gnome
> apps, but expect us to carry the cost of adapting them to your alternative
> backends.

Nice interpretation.