After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761258 - libgnome-desktop: don't install gnome-rr-debug
libgnome-desktop: don't install gnome-rr-debug
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-28 16:00 UTC by Cosimo Cecchi
Modified: 2016-02-03 15:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libgnome-desktop: don't install gnome-rr-debug (1.18 KB, patch)
2016-01-28 16:01 UTC, Cosimo Cecchi 		rejected Details | Review
libgnome-desktop: add an option to disable gnome-rr-debug (2.22 KB, patch)
2016-02-01 18:14 UTC, Cosimo Cecchi 		none Details | Review
libgnome-desktop: add an option to disable gnome-rr-debug (2.25 KB, patch)
2016-02-01 22:09 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-01-28 16:00:49 UTC 
See patch
Comment 1 Cosimo Cecchi 2016-01-28 16:01:00 UTC 
Created attachment 319950 [details] [review]
libgnome-desktop: don't install gnome-rr-debug

Not everyone needs to have this program installed. Just make it a noinst
target.
Comment 2 Bastien Nocera 2016-02-01 16:01:48 UTC 
Review of attachment 319950 [details] [review]:

We *do* want to install this by default, on distributions, as it makes debugging XRandR (and Wayland equivalent) issues much easier. I'd rather have a configure option to disable this instead.
Comment 3 Cosimo Cecchi 2016-02-01 18:14:07 UTC 
Created attachment 320206 [details] [review]
libgnome-desktop: add an option to disable gnome-rr-debug

Not everyone needs to have this program installed - e.g. when
gnome-desktop is bundled in an xdg-app.
Comment 4 Cosimo Cecchi 2016-02-01 18:14:39 UTC 
Comment on attachment 319950 [details] [review]
libgnome-desktop: don't install gnome-rr-debug

Made it a configure option like you suggested.
Comment 5 Bastien Nocera 2016-02-01 20:44:05 UTC 
Review of attachment 320206 [details] [review]:

This will fail to add gnome-rr-debug.c to the dist if it's compiled with --disable-debug-tools. You'll need to add gnome-rr-debug.c to EXTRA_DIST in the else case.
Comment 6 Cosimo Cecchi 2016-02-01 22:09:30 UTC 
Created attachment 320236 [details] [review]
libgnome-desktop: add an option to disable gnome-rr-debug

--

This seems to do the job - gnome-rr-debug.c was added to make dist with --disable-debug-tools.
Comment 7 Bastien Nocera 2016-02-03 15:22:51 UTC 
Attachment 320236 [details] pushed as 6f50c8a - libgnome-desktop: add an option to disable gnome-rr-debug