After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761252 - Misusage of LDFLAGS in configure.ac
Misusage of LDFLAGS in configure.ac
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-28 14:11 UTC by Mattias Hansson
Modified: 2016-05-23 06:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Revert caching of LDFLAGS (1.66 KB, patch)
2016-01-28 14:13 UTC, Mattias Hansson
none Details | Review
[PATCH] Correct the usage of LDFLAGS (1.28 KB, patch)
2016-01-28 14:14 UTC, Mattias Hansson
none Details | Review

Description Mattias Hansson 2016-01-28 14:11:22 UTC
The system LDFLAGS will be cached and therefore end up unused when checking for some libraries e.g. zlib. The reason is a temporary override of the LDFLAGS, followed by a re-assign to 'LDFLAGS="-L${Z_DIR}/lib"'. Libtool will therefore not search $(prefix)/usr/lib for the library if passed as a system LDFLAG. In order to solve this the developer is forced to configure with the option "--with-zlib=<path>" when the root cause to the issue is the usage of LIBS to store LDFLAGS. The misusage could result in a reverse order of LIBS and LDFLAGS.

The LDFLAGS cache was introduced here:
https://bugzilla.gnome.org/show_bug.cgi?id=737532

The usage of LIBS for storing LDFLAGS seems to have been in configure.{in,ac} since the file was create/renamed.
Comment 1 Mattias Hansson 2016-01-28 14:13:09 UTC
Created attachment 319940 [details] [review]
[PATCH] Revert caching of LDFLAGS
Comment 2 Mattias Hansson 2016-01-28 14:14:07 UTC
Created attachment 319941 [details] [review]
[PATCH] Correct the usage of LDFLAGS
Comment 3 Daniel Veillard 2016-05-23 06:04:42 UTC
Okay I tried to get this in I could not directly revert the first patch
as other changes happened, like for #749416, the second one applied fine
though. Commited as:

https://git.gnome.org/browse/libxml2/commit/?id=ebbd2b725fb206c3fede36c1366931088f89f462

and

https://git.gnome.org/browse/libxml2/commit/?id=40fd6d2a1b9dfc8ef5b428c9df7bdcb3398d6bd3

  I hope this solves the issue !

    thanks,

Daniel