After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761188 - Use primary@REALM as the presentation identity for temporary accounts
Use primary@REALM as the presentation identity for temporary accounts
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: Kerberos
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-27 16:12 UTC by Debarshi Ray
Modified: 2016-01-29 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
identity: Use primary@REALM to present temporary accounts (2.12 KB, patch)
2016-01-27 16:25 UTC, Debarshi Ray
committed Details | Review
identity: Remove obsolete comment (1.04 KB, patch)
2016-01-27 16:25 UTC, Debarshi Ray
committed Details | Review
kerberos: Remove redundant variable (2.41 KB, patch)
2016-01-27 17:08 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2016-01-27 16:12:56 UTC
Kerberos accounts added through the Settings -> Online Accounts UI are shown as primary@REALM (eg., dray@REDHAT.COM). However, those that are added via kinit (ie. temporary accounts) are only shown as REALM (eg., REDHAT.COM).

This is inconsistent in itself.

Moreover, for other providers (like Google, IMAP/SMTP, etc.) we try to show the full user facing (and user readable) string as much as possible. Essentially, this is the string that the user could be expected to type into a configuration dialog. eg., foo@bar.com that they use to log into Facebook, but not the human unreadable identifier that Facebook's API uses.

I think the original idea behind only using REALM was to avoid showing a longer string when there was only one account. However, we never did that for persistent accounts, and as I said, we usually show foo.bar@gmail.com, not gmail.com for the other types of accounts that we have.

Let's just use primary@REALM.
Comment 1 Debarshi Ray 2016-01-27 16:25:15 UTC
Created attachment 319857 [details] [review]
identity: Use primary@REALM to present temporary accounts
Comment 2 Debarshi Ray 2016-01-27 16:25:46 UTC
Created attachment 319858 [details] [review]
identity: Remove obsolete comment
Comment 3 Ray Strode [halfline] 2016-01-27 17:01:11 UTC
Review of attachment 319857 [details] [review]:

fine with me.
Comment 4 Ray Strode [halfline] 2016-01-27 17:01:43 UTC
Review of attachment 319858 [details] [review]:

nice, thanks.
Comment 5 Debarshi Ray 2016-01-27 17:08:55 UTC
Created attachment 319860 [details] [review]
kerberos: Remove redundant variable
Comment 6 Ray Strode [halfline] 2016-01-27 18:43:33 UTC
Review of attachment 319860 [details] [review]:

++
Comment 7 Debarshi Ray 2016-01-29 12:21:57 UTC
Comment on attachment 319860 [details] [review]
kerberos: Remove redundant variable

Thanks for the reviews, halfline!