GNOME Bugzilla – Bug 761126
winiconv: update to upstream version
Last modified: 2016-01-26 11:57:55 UTC
To update this code you need to fetch the last version of the code from: https://github.com/win-iconv/win-iconv Then you need to ensure 3 things: - the line ends are in unix format - some of the methods do not expose a const on the prototype refer to the commit b8c13a01b6bd5601eb3519dd3b20daed4bbc2e72 on how to fix it - fix one uninitialized variable if not yet fixed upstream refer to 7e0cb48dee9a8ecd87d403b7941ad3209eee658c
Created attachment 319739 [details] [review] winiconv: update to upstream version
This is not really a reviewable patch. It contains both winiconv->glob adaptations *and* winiconv commits since the last update, bundled into one big-ish diff. I don't think that it's necessay to review winiconv commits (presumably, winiconv maintainer(s) did that already, and know(s) the code better than i do), so i would propose separating this patch into 3 parts: 1) roll back any glib changes to winiconv 2) update winiconv 3) (re)apply any necessary glib changes to winiconv (1) and (2) could be merged into one (somewhat sloppy, but again, i would assume that glib-specific changes to winiconv that are already committed were reviewed earlier by someone, so a separate (1) patch is purely informative at this point, if it's possible to make it at all). Thus only part (3) would need reviewing.
For the record LRN already upstreamed 7e0cb48dee9a8ecd87d403b7941ad3209eee658c
Attachment 319739 [details] pushed as 9e805ff - winiconv: update to upstream version